On Thu, Sep 12, 2019 at 12:21:48AM -0700, Nathan Chancellor wrote: > From: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx> > > commit 8c5477e8046ca139bac250386c08453da37ec1ae upstream. > > Kernel build warns: > 'sanitize_boot_params' defined but not used [-Wunused-function] > > at below files: > arch/x86/boot/compressed/cmdline.c > arch/x86/boot/compressed/error.c > arch/x86/boot/compressed/early_serial_console.c > arch/x86/boot/compressed/acpi.c > > That's becausethey each include misc.h which includes a definition of > sanitize_boot_params() via bootparam_utils.h. > > Remove the inclusion from misc.h and have the c file including > bootparam_utils.h directly. > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Link: https://lkml.kernel.org/r/1563283092-1189-1-git-send-email-zhenzhong.duan@xxxxxxxxxx > [nc: Fixed conflict around lack of 67b6662559f7f] > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx> > --- > > Hi Greg and Sasha, > > Please consider applying this to 4.4 as it resolves a compilation error > with clang on 4.4 and it has already been applied to 4.9 and newer: > > https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/232287034 > > https://github.com/ClangBuiltLinux/linux/issues/654 > > Thanks to Ilie Halip for debugging this; TL;DR: clang pretends that it > is GCC 4.2.1 for glibc compatibility and this trips up a definition of > memcpy for GCC < 4.3. This is not an issue on mainline because GCC 4.6 > is the earliest supported GCC version so that code was removed and this > patch resolves it because string.h redefines memcpy to a proper version. Now queued up, thanks. greg k-h
