On Wed, Jan 22, 2014 at 12:01:23PM +0000, Steven Whitehouse wrote: > This is for 3.13-stable, 3.12-stable and 3.10-stable. It is upstream: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/gfs2/inode.c?id=62e96cf81988101fe9e086b2877307b6adda5197 > > Steve. Thanks Steven, I'm queuing it for the 3.11 kernel as well. Cheers, -- Luis > > >From 62e96cf81988101fe9e086b2877307b6adda5197 Mon Sep 17 00:00:00 2001 > From: Bob Peterson <rpeterso@xxxxxxxxxx> > Date: Mon, 6 Jan 2014 17:16:01 -0500 > Subject: GFS2: Increase i_writecount during gfs2_setattr_chown > > This patch calls get_write_access in function gfs2_setattr_chown, > which merely increases inode->i_writecount for the duration of the > function. That will ensure that any file closes won't delete the > inode's multi-block reservation while the function is running. > It also ensures that a multi-block reservation exists when needed > for quota change operations during the chown. > > Signed-off-by: Bob Peterson <rpeterso@xxxxxxxxxx> > Signed-off-by: Steven Whitehouse <swhiteho@xxxxxxxxxx> > > diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c > index 4acc584..51cf10d 100644 > --- a/fs/gfs2/inode.c > +++ b/fs/gfs2/inode.c > @@ -1623,10 +1623,22 @@ static int setattr_chown(struct inode *inode, struct iattr *attr) > if (!(attr->ia_valid & ATTR_GID) || gid_eq(ogid, ngid)) > ogid = ngid = NO_GID_QUOTA_CHANGE; > > - error = gfs2_quota_lock(ip, nuid, ngid); > + error = get_write_access(inode); > if (error) > return error; > > + error = gfs2_rs_alloc(ip); > + if (error) > + goto out; > + > + error = gfs2_rindex_update(sdp); > + if (error) > + goto out; > + > + error = gfs2_quota_lock(ip, nuid, ngid); > + if (error) > + goto out; > + > if (!uid_eq(ouid, NO_UID_QUOTA_CHANGE) || > !gid_eq(ogid, NO_GID_QUOTA_CHANGE)) { > error = gfs2_quota_check(ip, nuid, ngid); > @@ -1653,6 +1665,8 @@ out_end_trans: > gfs2_trans_end(sdp); > out_gunlock_q: > gfs2_quota_unlock(ip); > +out: > + put_write_access(inode); > return error; > } > > -- > 1.8.3.1 > > > > > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html