On Mon, Sep 02, 2019 at 07:18:23PM -0500, Mike Travis wrote: > +#ifdef UV1_HUB_IS_SUPPORTED All these ifdefs are dead code, please just remove them. Also it seems like at least the various mmr macros just check for a specific version, I think you are much better off just using a switch statement for the possible revisions there. > + return (uv_hub_info->hub_revision == UV4A_HUB_REVISION_BASE); And none of these braces are required.
