Re: [PATCH] IB/hfi1: Drop stale TID RDMA packets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 26, 2019 at 12:01:50PM -0400, Mike Marciniszyn wrote:
> From: Kaike Wan <kaike.wan@xxxxxxxxx>
> 
> Upstream commit d58c1834bf0d218a0bc00f8fb44874551b21da84.
> 
> In a congested fabric with adaptive routing enabled, traces show that
> the sender could receive stale TID RDMA NAK packets that contain newer
> KDETH PSNs and older Verbs PSNs. If not dropped, these packets could
> cause the incorrect rewinding of the software flows and the incorrect
> completion of TID RDMA WRITE requests, and eventually leading to memory
> corruption and kernel crash.
> 
> The current code drops stale TID RDMA ACK/NAK packets solely based
> on KDETH PSNs, which may lead to erroneous processing. This patch
> fixes the issue by also checking the Verbs PSN. Addition checks are
> added before rewinding the TID RDMA WRITE DATA packets.
> 
> [ported to 5.2 from upstream accounting for fspsn replacing flpsn.]

Now applied, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux