On 2019-8-18 11:21, Gao Xiang wrote: > From: Gao Xiang <gaoxiang25@xxxxxxxxxx> > > Richard observed a forever loop of erofs_read_raw_page() [1] > which can be generated by forcely setting ->u.i_blkaddr > to 0xdeadbeef (as my understanding block layer can > handle access beyond end of device correctly). > > After digging into that, it seems the problem is highly > related with directories and then I found the root cause > is an improper error handling in erofs_readdir(). > > Let's fix it now. > > [1] https://lore.kernel.org/r/1163995781.68824.1566084358245.JavaMail.zimbra@xxxxxx/ > > Reported-by: Richard Weinberger <richard@xxxxxx> > Fixes: 3aa8ec716e52 ("staging: erofs: add directory operations") > Cc: <stable@xxxxxxxxxxxxxxx> # 4.19+ > Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx> Thanks,
