Oops, you are totally right, I was still looking at the latest mlx5_ib_create_qp_resp struct while backporting these patches :) Sorry for that, Alessio On Mon, Aug 12, 2019 at 04:23:16PM +0200, Greg KH wrote: > On Mon, Aug 12, 2019 at 11:55:03AM +0100, Alessio Balsini wrote: > > From: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > > > > commit 0625b4ba1a5d4703c7fb01c497bd6c156908af00 upstream. > > > > mlx5_ib_create_qp_resp was never initialized and only the first 4 bytes > > were written. > > > > Fixes: 41d902cb7c32 ("RDMA/mlx5: Fix definition of mlx5_ib_create_qp_resp") > > This commit only showed up in the following kernel releases: > 4.17 4.18.7 4.19 > > so why is this "fix" commit needed in anything older than 4.17? > > That's why I did not backport it to older kernels, as I do not think it > is needed there. Do you? > > thanks, > > greg k-h