On Mon, Aug 05, 2019 at 02:35:13PM +0900, Masahiro Yamada wrote: > From: "M. Vefa Bicakci" <m.v.b@xxxxxxxxxx> > > commit 0c5b6c28ed68becb692b43eae5e44d5aa7e160ce upstream. > > Prior to this commit, starting nconfig, xconfig or gconfig, and saving > the .config file more than once caused data loss, where a .config file > that contained only comments would be written to disk starting from the > second save operation. > > This bug manifests itself because the SYMBOL_WRITTEN flag is never > cleared after the first call to conf_write, and subsequent calls to > conf_write then skip all of the configuration symbols due to the > SYMBOL_WRITTEN flag being set. > > This commit resolves this issue by clearing the SYMBOL_WRITTEN flag > from all symbols before conf_write returns. > > Fixes: 8e2442a5f86e ("kconfig: fix missing choice values in auto.conf") > Cc: linux-stable <stable@xxxxxxxxxxxxxxx> # 4.19+ > Signed-off-by: M. Vefa Bicakci <m.v.b@xxxxxxxxxx> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > --- > scripts/kconfig/confdata.c | 4 ++++ > 1 file changed, 4 insertions(+) 5.1.y is end-of-life, so no need for this backport. thanks, greg k-h