Re: [PATCH 3/8] drm/i915/userptr: Acquire the page lock around set_page_dirty()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Greg KH (2019-07-29 20:49:42)
> On Fri, Jul 26, 2019 at 10:35:51AM +0300, Joonas Lahtinen wrote:
> > From: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > 
> > set_page_dirty says:
> > 
> >       For pages with a mapping this should be done under the page lock
> >       for the benefit of asynchronous memory errors who prefer a
> >       consistent dirty state. This rule can be broken in some special
> >       cases, but should be better not to.
> > 
> > Under those rules, it is only safe for us to use the plain set_page_dirty
> > calls for shmemfs/anonymous memory. Userptr may be used with real
> > mappings and so needs to use the locked version (set_page_dirty_lock).
> > 
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203317
> > Fixes: 5cc9ed4b9a7a ("drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl")
> > References: 6dcc693bc57f ("ext4: warn when page is dirtied without buffers")
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > Link: https://patchwork.freedesktop.org/patch/msgid/20190708140327.26825-1-chris@xxxxxxxxxxxxxxxxxx
> > (cherry picked from commit cb6d7c7dc7ff8cace666ddec66334117a6068ce2)
> 
> This commit id is not in Linus's tree.
> 
> I've stopped here, and dropped patch 1/8 as well.  Please fix these all
> up to have the correct git ids and resend.

My bad. I was first requested to send an extra drm-intel-fixes PR, and
then to send directly to stable.

Now that the pull didn't get accepted, naturaly the IDs don't exist.

I'll send a fixed series.

Regards, Joonas



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux