Re: [PATCH 4.19 112/113] libnvdimm/bus: Stop holding nvdimm_bus_list_mutex over __nd_ioctl()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon 2019-07-29 21:23:19, Greg Kroah-Hartman wrote:
> From: Dan Williams <dan.j.williams@xxxxxxxxx>
> 
> commit b70d31d054ee3a6fc1034b9d7fc0ae1e481aa018 upstream.
> 
> In preparation for fixing a deadlock between wait_for_bus_probe_idle()
> and the nvdimm_bus_list_mutex arrange for __nd_ioctl() without
> nvdimm_bus_list_mutex held. This also unifies the 'dimm' and 'bus' level
> ioctls into a common nd_ioctl() preamble implementation.

Ok, so this is a preparation patch, not a fix...

> Marked for -stable as it is a pre-requisite for a follow-on fix.

...but follow-on fixes are going to be applied for 5.2 but not
4.19. So perhaps this one should not be in 4.19, either?

Best regards,
								Pavel

(Plus its quite complex).
>  drivers/nvdimm/bus.c     |   94 ++++++++++++++++++++++++++++-------------------
>  drivers/nvdimm/nd-core.h |    3 +

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux