RE: [PATCH] phy: renesas: rcar-gen3-usb2: Fix sysfs interface of "role"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Wednesday, July 31, 2019 6:27 PM
> 
> Hi Shimoda-san,
> 
> On Wed, Jul 31, 2019 at 11:04 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Since the role_store() uses strncmp(), it's possible to refer
> > out-of-memory if the sysfs data size is smaller than strlen("host").
> > This patch fixes it by using sysfs_streq() instead of strncmp().
> >
> > Reported-by: Pavel Machek <pavel@xxxxxxx>
> > Fixes: 9bb86777fb71 ("phy: rcar-gen3-usb2: add sysfs for usb role swap")
> > Cc: <stable@xxxxxxxxxxxxxxx> # v4.10+
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Thank you for your review!

> > ---
> >  Just a record. The role_store() doesn't need to check the count because
> >  the sysfs_streq() checks the first argument is NULL or not.
> 
> Is that wat you mean? sysfs_streq() doesn't seem to check for NULL pointers.

Oops, sorry for unclear. I meant a NULL-terminated string, not NULL pointer.

> Isn't the real reason that sysfs (kernfs) guarantees that the passed buffer
> is NUL-terminated?

I doesn't check in detail, but I assume so.

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux