On Thu, 18 Jul 2019 16:02:27 +0200
Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> On Thu, Jul 18, 2019 at 03:57:49PM +0200, Arnd Bergmann wrote:
> > gcc-9 complains about a blatant uninitialized variable use that
> > all earlier compiler versions missed:
> >
> > drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >
> > Return -EINVAL instead here and a few lines above it where
> > we accidentally return 0 on failure.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Yes, I checked the other error paths, too, and they look proper to me.
>
> Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>
Thanks for sorting that second case as well.
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
