On Wed, Jul 24, 2019 at 01:31:46AM +0300, Thomas Backlund wrote: > Den 23-07-2019 kl. 15:28, skrev Greg KH: > > On Tue, Jul 23, 2019 at 02:19:55PM +0200, Johannes Thumshirn wrote: > > > Hi Greg, > > > > > > please try the following: > > > > > > >From 9afa2d46ecb511259130eb51b4ab1feb1055d961 Mon Sep 17 00:00:00 2001 > > > From: Johannes Thumshirn <jthumshirn@xxxxxxx> > > > Date: Thu, 6 Jun 2019 12:07:15 +0200 > > > Subject: [PATCH] btrfs: correctly validate compression type > > > > > > (commit aa53e3bfac7205fb3a8815ac1c937fd6ed01b41e upstream) > > > > Worked for 5.1.y and 4.19.y, but not for the older ones. > > > > It applies to 5.1 but it does not build: > > + /usr/bin/make -O -j12 ARCH=x86_64 -s all > fs/btrfs/props.c: In function 'prop_compression_validate': > fs/btrfs/props.c:369:6: error: implicit declaration of function > 'btrfs_compression_is_valid_type'; did you mean > 'btrfs_compress_is_valid_type'? [-Werror=implicit-function-declaration] > if (btrfs_compression_is_valid_type(value, len)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > btrfs_compress_is_valid_type > cc1: some warnings being treated as errors Yes, now dropped from 5.1 and 4.19 trees. thanks, greg k-h