On Mon, Jul 22, 2019 at 2:25 PM Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx> wrote:
> On 7/22/19 12:10 PM, Arnd Bergmann wrote:
> >
> > Fixes: 42440c1f9911 ("lib/ubsan: add type mismatch handler for new GCC/Clang")
>
> There was no uaccess validataion at that time, so the right fixes line is probably this:
>
> Fixes: d08965a27e84 ("x86/uaccess, ubsan: Fix UBSAN vs. SMAP")
>
> > Link: > +CFLAGS_ubsan.o := $(call cc-option, -fno-conserve-stack) $(call cc-option, -fno-stack-protector) $(DISABLE_STACKLEAK_PLUGIN)
>
> $(call cc-option, -fno-conserve-stack) can be removed entirely. It's just copy paste from kasan Makefile.
> It was added in kasan purely for performance reasons.
Ok, I addressed both of these and sent an updated patch, thanks for the review.
Arnd
