On Wed, Jul 17, 2019 at 01:48:43PM -0300, Fabio Estevam wrote:
On Wed, Jul 17, 2019 at 1:30 PM Oleksandr Suvorov
<oleksandr.suvorov@xxxxxxxxxxx> wrote:
Change VAG power on/off control according to the following algorithm:
- turn VAG power ON on the 1st incoming event.
- keep it ON if there is any active VAG consumer (ADC/DAC/HP/Line-In).
- turn VAG power OFF when there is the latest consumer's pre-down event
come.
- always delay after VAG power OFF to avoid pop.
- delay after VAG power ON if the initiative consumer is Line-In, this
prevents pop during line-in muxing.
Also, according to the data sheet [1], to avoid any pops/clicks,
the outputs should be muted during input/output
routing changes.
[1] https://www.nxp.com/docs/en/data-sheet/SGTL5000.pdf
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@xxxxxxxxxxx>
Reviewed-by: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
Fixes: 9b34e6cc3bc2 ("ASoC: Add Freescale SGTL5000 codec support")
Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
By the way, I prefer the description you put in the cover letter as it
explicitly talks about a bug being fixed.
Yes. This patch describes itself as an improvement rather than a fix.
You need to add an explicit stable tag, rather than just cc us.
Something like:
Cc: stable@xxxxxxxxxx
--
Thanks,
Sasha
