On Tue, Jul 16, 2019 at 04:16:44PM +0900, Greg KH wrote: > On Tue, Jul 16, 2019 at 10:10:30AM +0300, Leon Romanovsky wrote: > > On Mon, Jul 15, 2019 at 05:19:13AM -0400, Selvin Xavier wrote: > > > GID entry consist of GID, vlan, netdev and smac. > > > Extend GID duplicate check companions to consider vlan_id as well > > > to support IPv6 VLAN based link local addresses. Introduce > > > a new structure (bnxt_qplib_gid_info) to hold gid and vlan_id information. > > > > > > The issue is discussed in the following thread > > > https://www.spinics.net/lists/linux-rdma/msg81594.html > > > > > > Fixes: 823b23da7113 ("IB/core: Allow vlan link local address based RoCE GIDs") > > > Cc: <stable@xxxxxxxxxxxxxxx> # v5.2+ > > > Reported-by: Yi Zhang <yi.zhang@xxxxxxxxxx> > > > > > Co-developed-by: Parav Pandit <parav@xxxxxxxxxxxx> > > > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > > > > I never understood why bad habits are so stinky. > > > > Can you please explain us what does it mean Co-developed-by and > > Signed-off-by of the same person in the same patch? > > See Documentation/process/submitting-patches.rst for what that tag > means. Read it, it doesn't help me to understand if I should now add Co-developed-by tag to most of RDMA Mellanox upstreamed patches, which already care my Signed-off-by, because I'm changing and fixing them many times. Maybe I should write for my upstreamed patched something like this? Co-developed-by: Leon R... Reviewed-By: Leon R... Tested-by: Leon R... Signed-by: Leon R... Thanks > > thanks, > > greg k-h
