On Mon, Jul 8, 2019 at 8:41 PM Andrew Lunn <andrew@xxxxxxx> wrote: > > > > Optional properties: > > > - interrupts: interrupt line number for the SMI error/done interrupt > > > -- clocks: phandle for up to three required clocks for the MDIO instance > > > +- clocks: phandle for up to four required clocks for the MDIO instance > > > > This needs to enumerate exactly what the clocks are. Shouldn't there > > be an additional clock-names value too? > > Hi Rob > > The driver does not care what they are called. It just turns them all > on, and turns them off again when removed. That's fine for the driver to do, but this is the hardware description. It's not just what they are called, but how many too. Is 1 clock in the DT valid? 0? It would be unusual for a given piece of h/w to function with a variable number of clocks. Rob
