Hi Greg,
43e28ba87708 ("ARM: dts: Use armada-370-xp as a base for armada-xp-98dx3236") is the patch
which introduces the armada-xp-98dx3236, and contains the device-tree entry for the driver that does
not behave correctly with this SoC.
However, the driver quirk that implements the fix does not exist until the two patches I mentioned :
b7639b0b15dd serial: 8250_dw: Limit dw8250_tx_wait_empty quirk to armada-38x devices
914eaf935ec7 serial: 8250_dw: Allow TX FIFO to drain before writing to UART_LCR
Before then, there is no "marvell,armada-38x-uart".
The current patch being delivered only changes the .dts to make use of the quirk. This won't work
if it's being delivered to a branch that does not have the above two patches. I had a look at linux-4.14.y
on kernel.org, and did not see the two patches there.
Cheers,
Joshua
________________________________________
From: gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx>
Sent: Monday, 8 July 2019 6:23 p.m.
To: Joshua Scott
Cc: andrew@xxxxxxx; gregory.clement@xxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; stable-commits@xxxxxxxxxxxxxxx
Subject: Re: Patch "ARM: dts: armada-xp-98dx3236: Switch to armada-38x-uart serial node" has been added to the 4.14-stable tree
On Mon, Jul 08, 2019 at 05:55:00AM +0000, Joshua Scott wrote:
> Hi,
>
> I do not think this patch alone will work on 4.14.
>
> An earlier pair of patches which implements the
> "marvell,armada-38x-uart" quirk is present on the other kernel
> versions, but I do see it as far back as 4.14.
>
> The following two patches are the ones which add support for that compatible string:
>
> b7639b0b15dd serial: 8250_dw: Limit dw8250_tx_wait_empty quirk to armada-38x devices
> 914eaf935ec7 serial: 8250_dw: Allow TX FIFO to drain before writing to UART_LCR
But, this patch says:
Fixes: 43e28ba87708 ("ARM: dts: Use armada-370-xp as a base for armada-xp-98dx3236")
and that commit showed up in 4.12.
If that is not the case, fine, I'll drop this, otherwise I just have to
go off of what is given to me :)
thanks,
greg k-h
