On Fri, Jun 28, 2019 at 11:42:30AM -0700, Srivatsa S. Bhat wrote: > From: Gen Zhang <blackgod016574@xxxxxxxxx> > > commit 425aa0e1d01513437668fa3d4a971168bbaa8515 upstream. > > In function ip_ra_control(), the pointer new_ra is allocated a memory > space via kmalloc(). And it is used in the following codes. However, > when there is a memory allocation error, kmalloc() fails. Thus null > pointer dereference may happen. And it will cause the kernel to crash. > Therefore, we should check the return value and handle the error. > > Signed-off-by: Gen Zhang <blackgod016574@xxxxxxxxx> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> > Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@xxxxxxxxxxxxx> > --- > > net/ipv4/ip_sockglue.c | 2 ++ > 1 file changed, 2 insertions(+) Unless you can actually trigger these kmalloc failures, I do not want to take these patches as they are not worth it at all. thanks, greg k-h
