On Tue, Jun 25, 2019 at 06:40:50PM -0400, Sasha Levin wrote: > On Tue, Jun 25, 2019 at 01:29:35PM -0700, Josh Hunt wrote: > > On 6/25/19 1:26 PM, Sasha Levin wrote: > > > On Tue, Jun 25, 2019 at 01:19:37PM -0400, Josh Hunt wrote: > > > > Backport of dad3a9314ac95dedc007bc7dacacb396ea10e376: > > > > > > You probably meant b6653b3629e5b88202be3c9abc44713973f5c4b4 here. > > > > I wasn't sure if I should reference the upstream commit or stable > > commit. dad3a9314 is the version of the commit from linux-4.14.y. There > > may be a similar issue with the Fixes tag below since that also > > references the 4.14 vers of the change. > > We try to just reference upstream commits when possible. I can edit > these if this patch will be merged. I think for this issue we will do as was mentioned in other responses in this thread. But, to the topic of original sha1 ids, I think I need to document how we have been using these in a much better way. It's a very powerful way to determine what is fixed where and allows people to properly audit fixes and how they propagate around different kernel trees, distros included. I've been talking to other projects and they like how we have been doing this and want to copy it, so I guess it's time to actually describe what we do here :) thanks, greg k-h
