On Mon, Jun 10, 2019 at 10:18:59AM -0300, Helen Koike wrote: > commit c16b85559dcfb5a348cc085a7b4c75ed49b05e2c upstream. > > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Calling drm_atomic_set_fb_for_plane() (which gets a reference of the new > fb and put the old fb) is not required, as it's taken care by > drm_mode_cursor_universal() when calling drm_atomic_helper_update_plane(). > > Cc: <stable@xxxxxxxxxxxxxxx> # v4.19+ > Fixes: 539c320bfa97 ("drm/vc4: update cursors asynchronously through atomic") > Suggested-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > Signed-off-by: Helen Koike <helen.koike@xxxxxxxxxxxxx> > Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > Link: https://patchwork.freedesktop.org/patch/msgid/20190603165610.24614-5-helen.koike@xxxxxxxxxxxxx > --- > > Hi, > > This patch failed to apply on kernel stable v4.19, I'm re-sending it > fixing the conflict. Now applied, thanks. greg k-h