On Tue, Jun 04, 2019 at 01:34:11PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 04, 2019 at 01:03:55PM +0200, David Sterba wrote: > > On Tue, Jun 04, 2019 at 10:19:20AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, May 29, 2019 at 01:57:52PM +0200, David Sterba wrote: > > > > On Wed, May 29, 2019 at 04:33:00AM -0700, Greg Kroah-Hartman wrote: > > > > > On Wed, May 29, 2019 at 01:23:14PM +0200, David Sterba wrote: > > > > > > Hi, > > > > > > > > > > > > upon closer inspection we found a problem with the patch > > > > > > > > > > > > "btrfs: Honour FITRIM range constraints during free space trim" > > > > > > > > > > > > that has been merged to 5.1.4. This could happen with ranged FITRIM > > > > > > where the range is not 'honoured' as it was supposed to. > > > > > > > > > > > > Please revert it and push in the next stable release so the buggy > > > > > > version is not in the wild for too long. > > > > > > > > > > > > Affected trees: > > > > > > > > > > > > 5.0.18 > > > > > > 5.1.4 > > > > > > 4.9.179 > > > > > > 4.19.45 > > > > > > 4.14.122 > > > > > > > > > > > > Master branch will have the revert too. Thanks. > > > > > > > > > > What is the git commit id of the revert in Linus's tree? > > > > > > > > The commit is not there yet, I'm going to send it with the next update > > > > in a few days for 5.2-rc2. > > > > > > > > To shorthen the delay I hope it's possible to revert the patches without > > > > the corresponding master commit but if you insist on that I'll send the > > > > pull request today and will let you know the commit id. > > > > > > Did this ever get reverted in Linus's tree? I can't seem to find it... > > > > The patches 2 and 4 from this patchset > > > > https://patchwork.kernel.org/project/linux-btrfs/list/?series=126297 > > > > will implement the equivalent change. Scheduled for merge to 5.2-rc4, > > the patches were not available last week. > > You might want to mark those for stable, if this is a big deal :) For the record, the mentioned upstream commit has been merged. Marking it for stable does not make sense as the stable trees already have the reverts.