Re: [PATCH] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hans,

> -	/* drives which fail FPDMA_AA activation (some may freeze afterwards) */
> -	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
> -	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
> +	/* drives which fail FPDMA_AA activation (some may freeze afterwards)
> +	   the ST disks also have LPM issues */
> +	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
> +						ATA_HORKAGE_NOLPM, },
> +	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
> +						ATA_HORKAGE_NOLPM, },

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

Slightly orthogonal, and I know it's been discussed before, but I think
it would be worth considering just blacklisting all firmware revs for
this model.

There were several firmware releases for these drives. And while it's
conceivable that post-2BA30001 may fix the issues, I think it's safe to
say that all the intermediate releases between the two we have are
equally broken.

-- 
Martin K. Petersen	Oracle Linux Engineering



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux