---------- Forwarded message ---------- From: Steve French <smfrench@xxxxxxxxx> Date: Mon, Jan 6, 2014 at 2:04 PM Subject: Re: Patch "cifs: set FILE_CREATED" has been added to the 3.10-stable tree To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> Cc: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Shirish Pargaonkar <spargaonkar@xxxxxxxx>, stable@xxxxxxxxxxxxxxx, stable-commits@xxxxxxxxxxxxxxx Shirish indicated that this was to fix a regression introduced in 3.12 (by VFS change commit 116cc0225381415b96551f725455d067f63a76a0 which changed the create path in the vfs in fs/namei.c) so I don't see it being needed for 3.10 or 3.11 unless the fs/namei.c change (commit116cc0225381415b96551f725455d067f63a76a0) were backported On Mon, Jan 6, 2014 at 1:20 PM, <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > This is a note to let you know that I've just added the patch titled > > cifs: set FILE_CREATED > > to the 3.10-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > cifs-set-file_created.patch > and it can be found in the queue-3.10 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > From f1e3268126a35b9d3cb8bf67487fcc6cd13991d8 Mon Sep 17 00:00:00 2001 > From: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> > Date: Wed, 11 Dec 2013 16:29:53 -0600 > Subject: cifs: set FILE_CREATED > > From: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> > > commit f1e3268126a35b9d3cb8bf67487fcc6cd13991d8 upstream. > > Set FILE_CREATED on O_CREAT|O_EXCL. > > cifs code didn't change during commit 116cc0225381415b96551f725455d067f63a76a0 > > Kernel bugzilla 66251 > > Signed-off-by: Shirish Pargaonkar <spargaonkar@xxxxxxxx> > Acked-by: Jeff Layton <jlayton@xxxxxxxxxx> > Signed-off-by: Steve French <smfrench@xxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > --- > fs/cifs/dir.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > --- a/fs/cifs/dir.c > +++ b/fs/cifs/dir.c > @@ -192,7 +192,7 @@ check_name(struct dentry *direntry) > static int > cifs_do_create(struct inode *inode, struct dentry *direntry, unsigned int xid, > struct tcon_link *tlink, unsigned oflags, umode_t mode, > - __u32 *oplock, struct cifs_fid *fid, int *created) > + __u32 *oplock, struct cifs_fid *fid) > { > int rc = -ENOENT; > int create_options = CREATE_NOT_DIR; > @@ -340,7 +340,6 @@ cifs_do_create(struct inode *inode, stru > .device = 0, > }; > > - *created |= FILE_CREATED; > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID) { > args.uid = current_fsuid(); > if (inode->i_mode & S_ISGID) > @@ -471,13 +470,16 @@ cifs_atomic_open(struct inode *inode, st > cifs_add_pending_open(&fid, tlink, &open); > > rc = cifs_do_create(inode, direntry, xid, tlink, oflags, mode, > - &oplock, &fid, opened); > + &oplock, &fid); > > if (rc) { > cifs_del_pending_open(&open); > goto out; > } > > + if ((oflags & (O_CREAT | O_EXCL)) == (O_CREAT | O_EXCL)) > + *opened |= FILE_CREATED; > + > rc = finish_open(file, direntry, generic_file_open, opened); > if (rc) { > if (server->ops->close) > @@ -520,7 +522,6 @@ int cifs_create(struct inode *inode, str > struct TCP_Server_Info *server; > struct cifs_fid fid; > __u32 oplock; > - int created = FILE_CREATED; > > cifs_dbg(FYI, "cifs_create parent inode = 0x%p name is: %s and dentry = 0x%p\n", > inode, direntry->d_name.name, direntry); > @@ -537,7 +538,7 @@ int cifs_create(struct inode *inode, str > server->ops->new_lease_key(&fid); > > rc = cifs_do_create(inode, direntry, xid, tlink, oflags, mode, > - &oplock, &fid, &created); > + &oplock, &fid); > if (!rc && server->ops->close) > server->ops->close(xid, tcon, &fid); > > > > Patches currently in stable-queue which might be from shirishpargaonkar@xxxxxxxxx are > > queue-3.10/cifs-set-file_created.patch -- Thanks, Steve -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html