This is a note to let you know that I've just added the patch titled
ceph: Avoid data inconsistency due to d-cache aliasing in readpage()
to the 3.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ceph-avoid-data-inconsistency-due-to-d-cache-aliasing-in-readpage.patch
and it can be found in the queue-3.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 56f91aad69444d650237295f68c195b74d888d95 Mon Sep 17 00:00:00 2001
From: Li Wang <liwang@xxxxxxxxxxxxxxx>
Date: Wed, 13 Nov 2013 15:22:14 +0800
Subject: ceph: Avoid data inconsistency due to d-cache aliasing in readpage()
From: Li Wang <liwang@xxxxxxxxxxxxxxx>
commit 56f91aad69444d650237295f68c195b74d888d95 upstream.
If the length of data to be read in readpage() is exactly
PAGE_CACHE_SIZE, the original code does not flush d-cache
for data consistency after finishing reading. This patches fixes
this.
Signed-off-by: Li Wang <liwang@xxxxxxxxxxxxxxx>
Signed-off-by: Sage Weil <sage@xxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/ceph/addr.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -210,9 +210,13 @@ static int readpage_nounlock(struct file
if (err < 0) {
SetPageError(page);
goto out;
- } else if (err < PAGE_CACHE_SIZE) {
+ } else {
+ if (err < PAGE_CACHE_SIZE) {
/* zero fill remainder of page */
- zero_user_segment(page, err, PAGE_CACHE_SIZE);
+ zero_user_segment(page, err, PAGE_CACHE_SIZE);
+ } else {
+ flush_dcache_page(page);
+ }
}
SetPageUptodate(page);
Patches currently in stable-queue which might be from liwang@xxxxxxxxxxxxxxx are
queue-3.12/ceph-allocate-non-zero-page-to-fscache-in-readpage.patch
queue-3.12/ceph-avoid-data-inconsistency-due-to-d-cache-aliasing-in-readpage.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html