Re: [PATCH] cifs: fix credits leak for SMB1 oplock breaks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 23, 2019 at 03:47:44PM -0700, Pavel Shilovsky wrote:
> From: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
> 
> Commit d69cb728e70c ("cifs: fix credits leak for SMB1 oplock breaks").
> 
> For SMB1 oplock breaks we would grab one credit while sending the PDU
> but we would never relese the credit back since we will never receive a
> response to this from the server. Eventuallt this would lead to a hang
> once all credits are leaked.
> 
> Fix this by defining a new flag CIFS_NO_SRV_RSP which indicates that there
> is no server response to this command and thus we need to add any credits
> back immediately after sending the PDU.
> 
> CC: Stable <stable@xxxxxxxxxxxxxxx> #v5.0+
> Signed-off-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
> Reviewed-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx>
> Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
> ---
>  fs/cifs/cifsglob.h  |  1 +
>  fs/cifs/cifssmb.c   |  2 +-
>  fs/cifs/transport.c | 10 +++++-----
>  3 files changed, 7 insertions(+), 6 deletions(-)

Now queued up, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux