Hi Philippe,
On 21/05/19 8:58 PM, Philippe Mazenauer wrote:
> Variables 'mv98dx3236_gating_desc' and 'mv98dx3236_coreclks' are
> declared static and initialized, but are not used in the file.
>
> ../drivers/clk/mvebu/armada-xp.c:213:41: warning: ‘mv98dx3236_gating_desc’ defined but not used [-Wunused-const-variable=]
> static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
> ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/clk/mvebu/armada-xp.c:171:38: warning: ‘mv98dx3236_coreclks’ defined but not used [-Wunused-const-variable=]
> static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> ^~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@xxxxxxxxxx>
The usage of these was moved to a separate file in a later commit and
the original code wasn't fully cleaned up.
Fixes: 337072604224 ("clk: mvebu: Expand mv98dx3236-core-clock support")
Cc: stable@xxxxxxxxxxxxxxx
Reviewed-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
Thanks
> ---
> drivers/clk/mvebu/armada-xp.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
> index fa1568279c23..2ae24a5debd0 100644
> --- a/drivers/clk/mvebu/armada-xp.c
> +++ b/drivers/clk/mvebu/armada-xp.c
> @@ -168,11 +168,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
> .num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
> };
>
> -static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> - .get_tclk_freq = mv98dx3236_get_tclk_freq,
> - .get_cpu_freq = mv98dx3236_get_cpu_freq,
> -};
> -
> /*
> * Clock Gating Control
> */
> @@ -210,15 +205,6 @@ static const struct clk_gating_soc_desc axp_gating_desc[] __initconst = {
> { }
> };
>
> -static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
> - { "ge1", NULL, 3, 0 },
> - { "ge0", NULL, 4, 0 },
> - { "pex00", NULL, 5, 0 },
> - { "sdio", NULL, 17, 0 },
> - { "xor0", NULL, 22, 0 },
> - { }
> -};
> -
> static void __init axp_clk_init(struct device_node *np)
> {
> struct device_node *cgnp =
>
