Re: [PATCH] power: supply: axp288_fuel_gauge: Add ACEPC T8 and T11 mini PCs to the blacklist

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Apr 22, 2019 at 10:43:01PM +0200, Hans de Goede wrote:
> The ACEPC T8 and T11 Cherry Trail Z8350 mini PCs use an AXP288 and as PCs,
> rather then portables, they does not have a battery. Still for some
> reason the AXP288 not only thinks there is a battery, it actually
> thinks it is discharging while the PC is running, slowly going to
> 0% full, causing userspace to shutdown the system due to the battery
> being critically low after a while.
>
> This commit adds the ACEPC T8 and T11 to the axp288 fuel-gauge driver
> blacklist, so that we stop reporting bogus battery readings on this device.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1690852
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---

Thanks, you made my day 😂. Queued to power-supply's for-next branch.

-- Sebastian

>  drivers/power/supply/axp288_fuel_gauge.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index 9ff2461820d8..368281bc0d2b 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -685,6 +685,26 @@ static void fuel_gauge_init_irq(struct axp288_fg_info *info)
>   * detection reports one despite it not being there.
>   */
>  static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
> +	{
> +		/* ACEPC T8 Cherry Trail Z8350 mini PC */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."),
> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "T8"),
> +			/* also match on somewhat unique bios-version */
> +			DMI_EXACT_MATCH(DMI_BIOS_VERSION, "1.000"),
> +		},
> +	},
> +	{
> +		/* ACEPC T11 Cherry Trail Z8350 mini PC */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."),
> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "T11"),
> +			/* also match on somewhat unique bios-version */
> +			DMI_EXACT_MATCH(DMI_BIOS_VERSION, "1.000"),
> +		},
> +	},
>  	{
>  		/* Intel Cherry Trail Compute Stick, Windows version */
>  		.matches = {
> -- 
> 2.21.0
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux