Re: [PATCH] mwl8k: Fix rate_idx underflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Petr Štetiar wrote:

> It was reported on OpenWrt bug tracking system[1], that several users
> are affected by the endless reboot of their routers if they configure
> 5GHz interface with channel 44 or 48.
> 
> The reboot loop is caused by the following excessive number of WARN_ON
> messages:
> 
>  WARNING: CPU: 0 PID: 0 at backports-4.19.23-1/net/mac80211/rx.c:4516
>                              ieee80211_rx_napi+0x1fc/0xa54 [mac80211]
> 
> as the messages are being correctly emitted by the following guard:
> 
>  case RX_ENC_LEGACY:
>       if (WARN_ON(status->rate_idx >= sband->n_bitrates))
> 
> as the rate_idx is in this case erroneously set to 251 (0xfb). This fix
> simply converts previously used magic number to proper constant and
> guards against substraction which is leading to the currently observed
> underflow.
> 
> 1. https://bugs.openwrt.org/index.php?do=details&task_id=2218
> 
> Fixes: 854783444bab ("mwl8k: properly set receive status rate index on 5 GHz receive")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Tested-by: Eubert Bao <bunnier@xxxxxxxxx>
> Reported-by: Eubert Bao <bunnier@xxxxxxxxx>
> Signed-off-by: Petr Štetiar <ynezz@xxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

6b583201fa21 mwl8k: Fix rate_idx underflow

-- 
https://patchwork.kernel.org/patch/10896599/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux