On 04/25 Christian wrote: >On Wed, Apr 24, 2019 at 6:16 PM Oleg Nesterov <oleg@xxxxxxxxxx> wrote: >> >> On 04/24, weizhenliang wrote: >> > >> > On 04/24, Oleg wrote: >> > >On 04/24, Christian Brauner wrote: >> > >> >> > >> On Wed, Apr 24, 2019 at 08:52:38PM +0800, Zhenliang Wei wrote: >> > >> >> > >> > Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx> >> > > >> > >Yes, but ... >> > > >> > >> > Reported-by: kbuild test robot <lkp@xxxxxxxxx> >> > > >> > >Hmm, really? >> > >> > Yes, the kbuild test robot says that if I fix the problem with the >> > third parameter type, I should add this tag. What is wrong or missing? >> >> But this patch does not fix the problem reported by robot, your patch >> (which introduced that problem) was dropped, the problem has gone. >> >> With this "Reported-by: kbuild test robot <lkp@xxxxxxxxx>" tag it >> looks as if test-robot has found the problem you are trying to fix: >> the lack of trace_signal_deliver(SIGKILL). > >Yeah, Oleg's absolutely right. That tag should just go. >The Fixes line is all that we want, I think. Got it ~ Thank you (Oleg and Christian) for the kind guidance And I will update the patch as soon as possible Wei.
