On Tue, Apr 23, 2019 at 12:08:32AM -0700, Nathan Chancellor wrote:
On Mon, Apr 22, 2019 at 02:22:39PM -0700, Matthias Kaehlcke wrote:Hi, recent clang version rightfully barf when they come across ADD_TO_DEVTABLE: scripts/mod/file2alias.c:1222:1: warning: adding 'unsigned long' to a string does not append to the string [-Wstring-plus-int] ADD_TO_DEVTABLE("mei", mei_cl_device_id, do_mei_entry); scripts/mod/file2alias.c:108:13: note: expanded from macro 'ADD_TO_DEVTABLE' device_id + 0*sizeof((function)((const char *)NULL, This can be addressed with the following upstream changes: f880eea68fe5 modpost: file2alias: check prototype of handler ec91e78d378c modpost: file2alias: go back to simple devtable lookup Could these be added to -stable? This affects all versions back to 4.4 (no clang support for older versions), though it's just a warning and the number of clang users with older kernels is probably fairly limited.[resending with Nick's correct email address] All of the clang commits have been backported to 4.4. It would be nice to have these commits because that warning is very noisy. Note, this will not apply cleanly to 4.4, 4.9, and 4.14. I have attached mbox files with the conflicts resolved, after build testing for arm64 and x86_64. 4.19 is a clean cherry pick for me. Also added Masahiro to CC.
I've queued all of these for 4.4-4.19, and they already exist in 5.0. Thanks all. -- Thanks, Sasha
