RE: [EXT] Re: [PATCH] scsi: ufs: Fix RX_TERMINATION_FORCE_ENABLE define value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Avri

>
>Hi,
>I tried to look it up in the unipro spec V1.6 (2013) - but it wasn't there.
>Is this attribute introduced on a later version?
>Thanks,
>Avri

It is in M-phy spec, 
RX_Termination_Force_Enable should be 0xA9, I think, here is typo.
But currently no driver uses it.


//Bean

>________________________________________
>From: Pedro Sousa <PedroM.Sousa@xxxxxxxxxxxx>
>Sent: Thursday, April 18, 2019 10:13 PM
>To: alim.akhtar@xxxxxxxxxxx; Avri Altman; martin.petersen@xxxxxxxxxx
>Cc: linux-scsi@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Pedro Sousa
>Subject: [PATCH] scsi: ufs: Fix RX_TERMINATION_FORCE_ENABLE define value
>
>Fix RX_TERMINATION_FORCE_ENABLE define value from 0x0089 to 0x00A9
>according to MIPI Alliance MPHY specification.
>
>Fixes: e785060ea3a1 ("ufs: definitions for phy interface")
>Cc: stable@xxxxxxxxxxxxxxx
>Signed-off-by: Pedro Sousa <sousa@xxxxxxxxxxxx>
>---
> drivers/scsi/ufs/unipro.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/ufs/unipro.h b/drivers/scsi/ufs/unipro.h index
>23129d7..c77e365 100644
>--- a/drivers/scsi/ufs/unipro.h
>+++ b/drivers/scsi/ufs/unipro.h
>@@ -52,7 +52,7 @@
> #define RX_HS_UNTERMINATED_ENABLE              0x00A6
> #define RX_ENTER_HIBERN8                       0x00A7
> #define RX_BYPASS_8B10B_ENABLE                 0x00A8
>-#define RX_TERMINATION_FORCE_ENABLE            0x0089
>+#define RX_TERMINATION_FORCE_ENABLE            0x00A9
> #define RX_MIN_ACTIVATETIME_CAPABILITY         0x008F
> #define RX_HIBERN8TIME_CAPABILITY              0x0092
> #define RX_REFCLKFREQ                          0x00EB
>--
>2.7.4





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux