Re: [PATCH] inet: update the IP ID generation algorithm to patch 355b98553789b646ed97ad801a619ff898471b92 standards.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 18, 2019 at 05:04:17PM +0000, Amit Klein wrote:
> Signed-off-by: Amit Klein <aksecurity@xxxxxxxxx>
> ---

Welcome to kernel development, here comes the learning curve!  :)

First off, as this is needed only for the stable kernels, we need to be
very explicit as to what kernel it is needed for, and why we can't just
take an upstream patch for it instead.

Also, I can't take a patch without any changelog text at all.  You need
to explain what this is, and why it is doing what it is doing.  See the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for a description of how to do this.

Fix that up and resend and we can go from there.

Oh, and thanks for writing the patch up in the first place.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux