Hi Greg,
FYI, this patch must go in the stable trees along with the below commit
which is in mainline else USB Host will break on OMAP3 platforms.
Same applies for 3.10 and 3.12 stable queues as well. Thanks.
commit 313a76ee11cda6700548afe68499ef174a240688
Author: Roger Quadros <rogerq@xxxxxx>
Date: Sun Dec 8 18:39:02 2013 -0700
ARM: OMAP2+: hwmod: Fix SOFTRESET logic
cheers,
-roger
On 12/18/2013 11:24 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> ARM: OMAP3: hwmod data: Don't prevent RESET of USB Host module
>
> to the 3.4-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> arm-omap3-hwmod-data-don-t-prevent-reset-of-usb-host-module.patch
> and it can be found in the queue-3.4 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
>
>
> From 7f4d3641e2548d1ac5dee837ff434df668a2810c Mon Sep 17 00:00:00 2001
> From: Roger Quadros <rogerq@xxxxxx>
> Date: Sun, 8 Dec 2013 18:39:02 -0700
> Subject: ARM: OMAP3: hwmod data: Don't prevent RESET of USB Host module
>
> From: Roger Quadros <rogerq@xxxxxx>
>
> commit 7f4d3641e2548d1ac5dee837ff434df668a2810c upstream.
>
> Unlike what the comment states, errata i660 does not state that we
> can't RESET the USB host module. Instead it states that RESET is the
> only way to recover from a deadlock situation.
>
> RESET ensures that the module is in a known good state irrespective
> of what bootloader does with the module, so it must be done at boot.
>
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> Tested-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> # Panda, BeagleXM
> Fixes: de231388cb80 ("ARM: OMAP: USB: EHCI and OHCI hwmod structures for OMAP3")
> Signed-off-by: Paul Walmsley <paul@xxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -3347,7 +3347,8 @@ static struct omap_hwmod_class_sysconfig
> .syss_offs = 0x0014,
> .sysc_flags = (SYSC_HAS_MIDLEMODE | SYSC_HAS_CLOCKACTIVITY |
> SYSC_HAS_SIDLEMODE | SYSC_HAS_ENAWAKEUP |
> - SYSC_HAS_SOFTRESET | SYSC_HAS_AUTOIDLE),
> + SYSC_HAS_SOFTRESET | SYSC_HAS_AUTOIDLE |
> + SYSS_HAS_RESET_STATUS),
> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
> MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART),
> .sysc_fields = &omap_hwmod_sysc_type1,
> @@ -3465,15 +3466,7 @@ static struct omap_hwmod omap3xxx_usb_ho
> * hence HWMOD_SWSUP_MSTANDBY
> */
>
> - /*
> - * During system boot; If the hwmod framework resets the module
> - * the module will have smart idle settings; which can lead to deadlock
> - * (above Errata Id:i660); so, dont reset the module during boot;
> - * Use HWMOD_INIT_NO_RESET.
> - */
> -
> - .flags = HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY |
> - HWMOD_INIT_NO_RESET,
> + .flags = HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY,
> };
>
> /*
>
>
> Patches currently in stable-queue which might be from rogerq@xxxxxx are
>
> queue-3.4/arm-omap3-hwmod-data-don-t-prevent-reset-of-usb-host-module.patch
>
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html