Hi, On Mon, Apr 15, 2019 at 11:10:49AM -0500, Dinh Nguyen wrote: > On 4/12/19 12:19 PM, Aaro Koskinen wrote: > > On Wed, Mar 13, 2019 at 09:29:56PM -0500, Dinh Nguyen wrote: > >> The gmac ethernet driver uses the "altr,sysmgr-syscon" property to > >> configure phy settings for the gmac controller. > >> > >> Add the "altr,sysmgr-syscon" property to all gmac nodes. > >> > >> This patch fixes: > >> > >> [ 0.917530] socfpga-dwmac ff800000.ethernet: No sysmgr-syscon node found > >> [ 0.924209] socfpga-dwmac ff800000.ethernet: Unable to parse OF data > >> > >> Cc: stable@xxxxxxxxxxxxxxx > >> Reported-by: Ley Foon Tan <ley.foon.tan@xxxxxxxxx> > >> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx> > > > > This patch broke the boot on my board when upgrading from v5.1-rc3 > > to -rc4 (using a simple custom DTS including socfpga_stratix10.dtsi, > > basically enabling just ethernet and serial console). Previously, when > > the socfpga-dwmac probe failed with above messages, the generic dwmac > > driver was used instead to get working networking. > > > > Now that the socfpga-dwmac probe succeeds, there's a sudden reset/crash > > due to exception. Apparently the reason is that the access to these > > registers is restricted from the kernel and the mainline socfpga-dwmac > > driver is missing the support for the SMC call access? Am I missing > > something, or was it too early to apply this patch to mainline? > > Argh, you're right! Apologies, but I think this patch is to early to > apply to mainline. As there was a patch that we have downstream to > support the SMC call access, I made a mistake and tested this patch with > it. Let me try to clean up the downstream patch for submission to fix this. Ok, thanks for comforming. > Meanwhile, are you ok with just using the generic dwmac driver to get > around this issue? Otherwise, I can ask the to revert the patch. Personally I'm fine with the generic dwmac for time being. A.
