Re: syncconfig changes in 4.19.34 break builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sasha,

On Wed, Apr 10, 2019 at 12:39 AM Sasha Levin <sashal@xxxxxxxxxx> wrote:
>
> On Tue, Apr 09, 2019 at 02:50:04PM +0900, Masahiro Yamada wrote:
> >Greg, Sasha,
> >
> >
> >Sorry, the commit ID was wrong.
> >
> >
> >The following commit for 4.19.x:
> >
> >commit 02826a6ba301b72461c3706e1cc66d5571cd327e
> >Author: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> >Date:   Mon Nov 5 16:52:34 2018 +0900
> >
> >    kbuild: deb-pkg: fix bindeb-pkg breakage when O= is used
>
> This commit claims it's fixing 80463f1b7bf9, which is not in 4.19. Was
> that a mistake in the commit message?

No.  The commit message is correct.
The Fixes: tag points to the first bad commit in _upstream_.


What I want to say is:
638ecaf58369 [which was 9390dff66a5 in upstream]
depends on 02826a6ba301b, which is missing in v4.19.x branch.

638ecaf58369 was cherry-picked without correct patch
dependency, so it got broken. That's all.


There are two options to fix the breakage:
 - backport 02826a6ba301b
    OR
 - revert 638ecaf58369.


-- 
Best Regards
Masahiro Yamada



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux