On Thu, Mar 28, 2019 at 02:44:32PM +0300, Heikki Krogerus wrote:
> commit 23481121c81d984193edf1532f5e123637e50903 upstream.
>
> It is not possible to use the parent of the port device when
> requesting mux handles as the parent may be a multiport USB
> Type-C or PD controller. The muxes must be assigned to the
> ports, not the controllers.
>
> This will also move the requesting of the muxes after the
> port device is initialized.
>
> [ heikki: This patch fixes an issue where port->id was used uninitialized. ]
>
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.19.x: cd7753d: drivers: base: Helpers for adding device connection descriptions
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.19.x: 140a4ec: platform: x86: intel_cht_int33fe: Register all connections at once
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.19.x: 78d2b54: platform: x86: intel_cht_int33fe: Add connection for the DP alt mode
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.19.x: 495965a: platform: x86: intel_cht_int33fe: Add connections for the USB Type-C port
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.19.x
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.19.x: 148b0aa: platform: x86: intel_cht_int33fe: Remove the old connections for the muxes
> Fixes: bdecb33af34f ("usb: typec: API for controlling USB Type-C Multiplexers")
> Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> Hi,
>
> This is a request to backport commit 23481121c81d984193edf1532f5e123637e50903
>
> It was not marked as a fix, but it does fix an issue where a
> variable "port->id" was used in function typec_register_port()
> without initializing it.
>
> The patch has additional prerequisites which are listed in
> the sign-off area. Please note that there is also one patch
> listed there after this one.
Ok, all are now queued up. Please let me know if I missed anything.
thanks,
greg k-h
