This is a note to let you know that I've just added the patch titled
[PATCH linux-3.10.y] ip6tnl: fix use after free of fb_tnl_dev
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ip6tnl-fix-use-after-free-of-fb_tnl_dev.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From nicolas.dichtel@xxxxxxxxx Wed Dec 18 12:35:05 2013
From: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
Date: Fri, 13 Dec 2013 10:06:35 +0100
Subject: [PATCH linux-3.10.y] ip6tnl: fix use after free of fb_tnl_dev
To: netdev@xxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx
Cc: gregkh@xxxxxxxxxxxxxxxxxxx, rostedt@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, williams@xxxxxxxxxx, linux-rt-users@xxxxxxxxxxxxxxx, lclaudio@xxxxxxxx, Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
Message-ID: <1386925595-4995-1-git-send-email-nicolas.dichtel@xxxxxxxxx>
The upstream commit bb8140947a24 ("ip6tnl: allow to use rtnl ops on fb tunnel")
(backported into linux-3.10.y) left a bug which was fixed upstream by commit
1e9f3d6f1c40 ("ip6tnl: fix use after free of fb_tnl_dev").
The problem is a bit different in linux-3.10.y, because there is no x-netns
support (upstream commit 0bd8762824e7 ("ip6tnl: add x-netns support")).
When ip6_tunnel.ko is unloaded, FB device is deleted by rtnl_link_unregister()
and then we try to delete it again in ip6_tnl_destroy_tunnels().
This patch removes the second deletion.
Reported-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
Suggested-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
Cc: David Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/ipv6/ip6_tunnel.c | 2 --
1 file changed, 2 deletions(-)
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -1711,8 +1711,6 @@ static void __net_exit ip6_tnl_destroy_t
}
}
- t = rtnl_dereference(ip6n->tnls_wc[0]);
- unregister_netdevice_queue(t->dev, &list);
unregister_netdevice_many(&list);
}
Patches currently in stable-queue which might be from nicolas.dichtel@xxxxxxxxx are
queue-3.10/ip6tnl-fix-use-after-free-of-fb_tnl_dev.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html