On Wed, Mar 27, 2019 at 04:26:26PM +0800, Ming Lei wrote: > On Wed, Mar 27, 2019 at 4:15 PM Christoph Hellwig <hch@xxxxxx> wrote: > > > > On Tue, Mar 26, 2019 at 03:37:36PM +0800, Ming Lei wrote: > > > On Tue, Mar 26, 2019 at 3:36 PM Christoph Hellwig <hch@xxxxxx> wrote: > > > > > > > > Note that in many cases allocating larger pages in the other targets > > > > would be useful. Given that you fix the one places where we made a page > > > > size assumption I don't see a great need to limit outselves here. > > > > > > block device backed ns still needs this patch. > > > > Then we need to fix that code as well. Or even better make bio_add_page > > handle the larger than page case fine if it really doesn't do that yet. > > Given loop is the only exception, this patch is exactly the fix, right? Well, we want to be able to pass multi-page biovecs everywhere, so I think we'd just solve this based on loop so that we can later take advantage of it everywhere.
