On Fri, Mar 22, 2019 at 09:37:48PM +0000, Souza, Jose wrote: > On Fri, 2019-03-22 at 22:49 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > If I'm reading the spec right AML 0x87CA is a Y SKU, so it > > should be marked as ULX in our old style terminology. > > You are right, only the CPU is based on CFL. > > Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx> Thanks. Pushed. > > > > > Cc: stable@xxxxxxxxxxxxxxx > > Cc: José Roberto de Souza <jose.souza@xxxxxxxxx> > > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Fixes: c0c46ca461f1 ("drm/i915/aml: Add new Amber Lake PCI ID") > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/i915/i915_drv.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h > > b/drivers/gpu/drm/i915/i915_drv.h > > index f723b15527f8..428279fd88a0 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.h > > +++ b/drivers/gpu/drm/i915/i915_drv.h > > @@ -2361,7 +2361,8 @@ static inline unsigned int > > i915_sg_segment_size(void) > > INTEL_DEVID(dev_priv) == 0x5915 || \ > > INTEL_DEVID(dev_priv) == 0x591E) > > #define IS_AML_ULX(dev_priv) (INTEL_DEVID(dev_priv) == 0x591C || \ > > - INTEL_DEVID(dev_priv) == 0x87C0) > > + INTEL_DEVID(dev_priv) == 0x87C0 || \ > > + INTEL_DEVID(dev_priv) == 0x87CA) > > #define IS_SKL_GT2(dev_priv) (IS_SKYLAKE(dev_priv) && \ > > INTEL_INFO(dev_priv)->gt == 2) > > #define IS_SKL_GT3(dev_priv) (IS_SKYLAKE(dev_priv) && \ -- Ville Syrjälä Intel