On Wed, Mar 20, 2019 at 08:28:44PM -0400, Sasha Levin wrote: > On Wed, Mar 20, 2019 at 06:50:00PM -0500, Samuel Holland wrote: > > On 03/20/19 17:27, Eric Biggers wrote: > > > queue-4.14/clocksource-drivers-arch_timer-workaround-for-allwinner-a64-timer-instability.patch > > > causes a build error: > > > > > > CC drivers/clocksource/arm_arch_timer.o > > > drivers/clocksource/arm_arch_timer.c:433:4: error: 'const struct arch_timer_erratum_workaround' has no member named 'read_cntpct_el0'; did you mean 'read_cntvct_el0'? > > > .read_cntpct_el0 = sun50i_a64_read_cntpct_el0, > > > ^~~~~~~~~~~~~~~ > > > read_cntvct_el0 > > > make[1]: *** [scripts/Makefile.build:327: drivers/clocksource/arm_arch_timer.o] Error 1 > > > make: *** [Makefile:1686: drivers/clocksource/arm_arch_timer.o] Error 2 > > > > 4.14 looks to be before the kernel switched to using CNTPCT internally, so that > > hook doesn't exist. The line should be removed. (sun50i_a64_read_cntpct_el0 > > still needs to be there for the .read_cntp_tval_el0 implementation.) > > > > Apologies for the breakage, > > Samuel > > I've dropped it from 4.14, thanks all! I don't see it dropped in the public tree, so I've dropped it for real now :) thanks, greg k-h
