On Wed, Mar 20, 2019 at 08:32:07PM +0300, Maxim Zhukov wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> commit 251b7aea34ba3c4d4fdfa9447695642eb8b8b098 upstream
>
> The memcpy()s in the PCBC implementation use walk->iv as both the source
> and destination, which has undefined behavior. These memcpy()'s are
> actually unneeded, because walk->iv is already used to hold the previous
> plaintext block XOR'd with the previous ciphertext block. Thus,
> walk->iv is already updated to its final value.
>
> So remove the broken and unnecessary memcpy()s.
>
> Fixes: 91652be5d1b9 ("[CRYPTO] pcbc: Add Propagated CBC template")
> Cc: <stable@xxxxxxxxxxxxxxx> # v2.6.21+
> Cc: David Howells <dhowells@xxxxxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Maxim Zhukov <mussitantesmortem@xxxxxxxxx>
> ---
> crypto/pcbc.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
Thanks for all of the backports, now queued up.
greg k-h
