Re: [PATCH-3.10.y-3.11.y] staging: comedi: pcmmio: remove unneeded checks on detach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013-12-12 13:41, Ian Abbott wrote:
follow 	b88e75bb6576d99e0ba4f6edc978293d1ff9c01b

As pointed out by Dan carpenter for the similar pcmuio driver, there is
no need to check the pointer passed to `kfree()`, so remove that check
from `pcmmio_detach()`.

Also, check the `devpriv` (`dev->private`) pointer once, outside the
`for` loop.

Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
---
Applies to 3.10.y and 3.11.y only.
Not needed for other kernels.

Actually, please ignore this patch. I've just realized it isn't needed as devpriv is checked inside the for loop before it is dereferenced.

Sorry for the noise.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]