Re: [PATCH] ALSA: firewire-motu: fix construction of PCM frame for capture direction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 26 Feb 2019 05:38:37 +0100,
Takashi Sakamoto wrote:
> 
> In data blocks of common isochronous packet for MOTU devices, PCM
> frames are multiplexed in a shape of '24 bit * 4 Audio Pack', described
> in IEC 61883-6. The frames are not aligned to quadlet.
> 
> For capture PCM substream, ALSA firewire-motu driver constructs PCM
> frames by reading data blocks byte-by-byte. However this operation
> includes bug for lower byte of the PCM sample. This brings invalid
> content of the PCM samples.
> 
> This commit fixes the bug.
> 
> Reported-by: Peter Sjöberg <autopeter@xxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v4.12+
> Fixes: 4641c9394010 ("ALSA: firewire-motu: add MOTU specific protocol layer")
> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>

Applied, thanks.


Takashi



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux