On 12/10/2013 12:13 AM, Jan Beulich wrote:
>>>> On 10.12.13 at 06:09, John Stultz <john.stultz@xxxxxxxxxx> wrote:
>> static cycle_t logarithmic_accumulation(struct timekeeper *tk, cycle_t offset,
>> - u32 shift)
>> + u32 shift, int *action)
> With plain int used here, ...
>
>> @@ -1369,7 +1369,7 @@ static void update_wall_time(void)
>> struct timekeeper *tk = &shadow_timekeeper;
>> cycle_t offset;
>> int shift = 0, maxshift;
>> - unsigned int action;
>> + unsigned int action = 0;
> ... and unsigned int used here, ...
>
>> @@ -1404,7 +1404,7 @@ static void update_wall_time(void)
>> maxshift = (64 - (ilog2(ntp_tick_length())+1)) - 1;
>> shift = min(shift, maxshift);
>> while (offset >= tk->cycle_interval) {
>> - offset = logarithmic_accumulation(tk, offset, shift);
>> + offset = logarithmic_accumulation(tk, offset, shift, &action);
> ... does this compile without warning for you?
It does compile without a warning, but I'll fix it none the less!
Thanks for pointing this out!
-john
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html