Re: WTF: patch "[PATCH] ARC: enable uboot support unconditionally" was seriously submitted to be applied to the 4.20-stable tree?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 25, 2019 at 02:54:00PM +0100, Greg KH wrote:
> On Mon, Feb 25, 2019 at 10:43:47AM +0100, LABBE Corentin wrote:
> > On Sun, Feb 24, 2019 at 02:54:28PM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > > The patch below was submitted to be applied to the 4.20-stable tree.
> > > 
> > > I fail to see how this patch meets the stable kernel rules as found at
> > > Documentation/process/stable-kernel-rules.rst.
> > > 
> > > I could be totally wrong, and if so, please respond to 
> > > <stable@xxxxxxxxxxxxxxx> and let me know why this patch should be
> > > applied.  Otherwise, it is now dropped from my patch queues, never to be
> > > seen again.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > 
> > Hello
> > 
> > Without this patch, we cannot boot a defconfig on ARC, and this is
> > critical for testing ARC devices in kernelCI.
> 
> But this means you have never been able to boot a defconfig on ARC,
> right?  So this is a new "feature" you are adding :)

No I was able to boot them, but by adding CONFIG_ARC_UBOOT_SUPPORT.
This patch remove the assertion that ARC devices will be booted by default for debugging purpose.

> 
> If you wait one more week, all is good, you can do this for 5.0, and
> when I drop 4.20 in another few weeks, all is fine.
> 
> > Why this patch is not a real stable patch, it is a strong requirement
> > for testing all future stable release on kernelCI.
> 
> Only for 4.20.
> 
> And normally kernelci uses a specific configuration for the board it is
> testing, not defconfig.  Or am I mistaken?

No, kernelci only build defconfig without touching them.

> 
> This is a fine patch to have upstream, it just really doesn't fit the
> stable rules.
> 
> > Note that another patch (touching defconfig) for booting defconfig is
> > still missing and need to be also added to stable. (I will resend it
> > today)
> 
> Again, looks like a new feature.  Just wait a week and all will be fine
> for you :)
> 



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux