On Fri, Feb 22, 2019 at 10:01:03AM +0000, Marc Zyngier wrote: > On Thu, 21 Feb 2019 11:42:32 +0000 > Dave Martin <Dave.Martin@xxxxxxx> wrote: > > > Due to what looks like a typo dating back to the original addition > > of FPEXC32_EL2 handling, KVM currently initialises this register to > > an architecturally invalid value. > > > > As a result, the VECITR field (RES1) in bits [10:8] is initialised > > with 0, and the two reserved (RES0) bits [6:5] are initialised with > > 1. (In the Common VFP Subarchitecture as specified by ARMv7-A, > > these two bits were IMP DEF. ARMv8-A removes them.) > > > > This patch changes the reset value from 0x70 to 0x700, which > > reflects the architectural constraints and is presumably what was > > originally intended. > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 4.12.x- > > Cc: Marc Zyngier <marc.zyngier@xxxxxxx> > > Cc: Christoffer Dall <christoffer.dall@xxxxxxx> > > Fixes: 62a89c44954f ("arm64: KVM: 32bit handling of coprocessor traps") > > Signed-off-by: Dave Martin <Dave.Martin@xxxxxxx> > > Applied to -next. > > Thanks, Thanks. I have a patch for <= v4.11 which I can send to stable once this patch reaches torvalds/master. Is it worth it though, in your opinion? Cheers ---Dave