On Mon, Feb 18, 2019 at 09:14:03AM +0000, Sudip Mukherjee wrote: > Hi Sasha, > > On Sun, Feb 17, 2019 at 09:06:36PM -0500, Sasha Levin wrote: > > On Fri, Feb 15, 2019 at 12:26:35PM +0000, Chris Redpath wrote: > > > Hi Greg et al. > > > > > > A user of android-4.14 has pointed the following missing commit out. > > > > > > Commit 3054426dc68e ("sched, trace: Fix prev_state output in sched_switch tracepoint") was put into linux-4.20 around rc5 to fix an issue in a tracepoint. According to the patch itself, the broken commit was 3f5fe9fef5b2 ("sched/debug: Fix task state recording/printout") which was merged at what looks like 4.15-rc2. The broken commit was also picked for 4.14.64 as 13f12749af15 ("sched/debug: Fix task state recording/printout"). The fix (3054426dc68e) was pulled into 4.19. but was not called out as needing to go back to 4.14. > > > > > > Is it possible to pick 3054426dc68e ("sched, trace: Fix prev_state output in sched_switch tracepoint") for the next stable 4.14 release? If not I can do a backport for android-4.14, just let me know. > > > > It wasn't backported because it didn't apply cleanly, since 4.4's > > backport of 3f5fe9fef5b2 differs from Linus's tree. > > > > The backport for that commit was done by Sudip (Cc'ed). I'll be happy to > > take a backport of 3054426dc68e if someone sense one my way. > > Happy to do a backport for 4.14-stable. :) > > It did not apply before as the function was only renamed by: > 1d48b080bcce ("sched/debug: Rename task-state printing helpers") > > There was no other functionality change. Now queued up, thanks. greg k-h