Re: [PATCH 5/8 v3] ubifs: Drop softlimit and delta fields from struct ubifs_wbuf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 17, 2019 at 7:16 PM Sasha Levin <sashal@xxxxxxxxxx> wrote:
> On Thu, Feb 14, 2019 at 02:24:00PM +0100, Linus Walleij wrote:
> >From: Rafał Miłecki <rafal@xxxxxxxxxx>
> >
> >commit 854826c9d526fd81077742c3b000e3f7fcaef3ce upstream.
> >
> >Values of these fields are set during init and never modified. They are
> >used (read) in a single function only. There isn't really any reason to
> >keep them in a struct. It only makes struct just a bit bigger without
> >any visible gain.
> >
> >Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
> >Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> >Signed-off-by: Richard Weinberger <richard@xxxxxx>
> >Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> This one is a cleanup, why is it needed in -stable?

I suppose just a prerequisite for 6/8 which was a feature,
so let's drop this one too.

Thanks!
Linus Walleij




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux