On Mon, Feb 11, 2019 at 07:02:06PM -0600, Eric W. Biederman wrote: > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes: > > > 4.20-stable review patch. If anyone has any objections, please let me > > know. > > No objection. But I think of this as a feature addition rather than a > fix for something. As a feature that we now allow something we > previously did not does this qualify for a backport to stable? > > It is probably no more harmful in this instance than adding PCI IDs to a > driver. So I am not worried. I am curious the current guidelines > are. > > In most cases a small relaxation of permissions like this requires a lot > of bug fixing as typically code protected by capable(CAP_XXX) has been > written and tested assuming a trusted root user. Those bug fixes are > many times too large for a stable backport. Fair enough, patch is now dropped, thanks for the review. greg k-h