This is a note to let you know that I've just added the patch titled
SCSI: hpsa: do not discard scsi status on aborted commands
to the 3.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-hpsa-do-not-discard-scsi-status-on-aborted-commands.patch
and it can be found in the queue-3.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 2e311fbabdc23b7eaec77313dc3b9a151a5407b5 Mon Sep 17 00:00:00 2001
From: "Stephen M. Cameron" <scameron@xxxxxxxxxxxxxxxxxx>
Date: Mon, 23 Sep 2013 13:33:41 -0500
Subject: SCSI: hpsa: do not discard scsi status on aborted commands
From: "Stephen M. Cameron" <scameron@xxxxxxxxxxxxxxxxxx>
commit 2e311fbabdc23b7eaec77313dc3b9a151a5407b5 upstream.
We inadvertantly discarded the scsi status for aborted commands.
For some commands (e.g. reads from tape drives) these can't be retried,
and if we discarded the scsi status, the scsi mid layer couldn't notice
anything was wrong and the error was not reported.
Signed-off-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
Signed-off-by: James Bottomley <JBottomley@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -1219,7 +1219,7 @@ static void complete_scsi_command(struct
"has check condition: aborted command: "
"ASC: 0x%x, ASCQ: 0x%x\n",
cp, asc, ascq);
- cmd->result = DID_SOFT_ERROR << 16;
+ cmd->result |= DID_SOFT_ERROR << 16;
break;
}
/* Must be some other type of check condition */
Patches currently in stable-queue which might be from scameron@xxxxxxxxxxxxxxxxxx are
queue-3.4/scsi-hpsa-do-not-discard-scsi-status-on-aborted-commands.patch
queue-3.4/scsi-hpsa-return-0-from-driver-probe-function-on-success-not-1.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html